test/cctest/asmjs/test-asm-typer.cc - Issue 2398023002: [wasm] asm.js - Parse and convert asm.js to wasm a function at a time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/asmjs/test-asm-typer.cc

Issue 2398023002: [wasm] asm.js - Parse and convert asm.js to wasm a function at a time. (Closed)

Patch Set: review fixes + fix asan forward reference failure Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/asmjs/test-asm-typer.cc

diff --git a/test/cctest/asmjs/test-asm-typer.cc b/test/cctest/asmjs/test-asm-typer.cc

index d345774dbf0efa5a856d20863f1ccce99a52f11f..05535f9045b7b1ff3032d976aa72e4b601772f72 100644

--- a/test/cctest/asmjs/test-asm-typer.cc

+++ b/test/cctest/asmjs/test-asm-typer.cc

@@ -126,7 +126,7 @@ class AsmTyperHarnessBuilder {

WithGlobal(var_name, type);

auto* var_info = typer_->Lookup(DeclareVariable(var_name));

CHECK(var_info);

- var_info->FirstForwardUseIs(nullptr);

+ var_info->FirstForwardUseIs(-1);

return this;

}