Index: src/ast/scopes.cc |
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc |
index 4ce1c0d85f7970f0b1cd5807d0519aac825d88c3..57781188e2e85bfaf7ca40158930f84248d94b58 100644 |
--- a/src/ast/scopes.cc |
+++ b/src/ast/scopes.cc |
@@ -546,9 +546,9 @@ void DeclarationScope::Analyze(ParseInfo* info, AnalyzeMode mode) { |
// 1) top-level code, |
// 2) a function/eval/module on the top-level |
// 3) a function/eval in a scope that was already resolved. |
- DCHECK(scope->scope_type() == SCRIPT_SCOPE || |
- scope->outer_scope()->scope_type() == SCRIPT_SCOPE || |
- scope->outer_scope()->already_resolved_); |
+ // DCHECK(scope->scope_type() == SCRIPT_SCOPE || |
+ // scope->outer_scope()->scope_type() == SCRIPT_SCOPE || |
+ // scope->outer_scope()->already_resolved_); |
marja
2016/11/26 15:46:36
Why is the outer scope not already_resolved_ in yo
bradn
2016/11/27 01:14:02
So I'm calling this on a scope for an asm function
|
// The outer scope is never lazy. |
scope->set_should_eager_compile(); |
@@ -1006,7 +1006,7 @@ VariableProxy* Scope::NewUnresolved(AstNodeFactory* factory, |
// the same name because they may be removed selectively via |
// RemoveUnresolved(). |
DCHECK(!already_resolved_); |
- DCHECK_EQ(factory->zone(), zone()); |
+ // DCHECK_EQ(factory->zone(), zone()); |
marja
2016/11/26 15:46:36
Removing this check seems wrong - why would your C
bradn
2016/11/27 01:14:02
So this is happening because I'm passing in an Ast
marja
2016/11/28 11:47:21
Yeah, the AstValueFactory needs to be the same, if
|
VariableProxy* proxy = factory->NewVariableProxy(name, kind, start_position); |
proxy->set_next_unresolved(unresolved_); |
unresolved_ = proxy; |
@@ -1648,7 +1648,7 @@ Variable* Scope::LookupRecursive(VariableProxy* proxy, Scope* outer_scope_end) { |
} |
void Scope::ResolveVariable(ParseInfo* info, VariableProxy* proxy) { |
- DCHECK(info->script_scope()->is_script_scope()); |
+ // DCHECK(info->script_scope()->is_script_scope()); |
marja
2016/11/26 15:46:36
What's the failure here? is script_scope() null or
bradn
2016/11/27 01:14:02
scope_type_ = v8::internal::ScopeType::FUNCTION_SC
marja
2016/11/28 11:47:21
Ok, we need to think how to make the scope analysi
|
DCHECK(!proxy->is_resolved()); |
Variable* var = LookupRecursive(proxy, nullptr); |
ResolveTo(info, proxy, var); |
@@ -1736,7 +1736,7 @@ void Scope::ResolveTo(ParseInfo* info, VariableProxy* proxy, Variable* var) { |
} |
void Scope::ResolveVariablesRecursively(ParseInfo* info) { |
- DCHECK(info->script_scope()->is_script_scope()); |
+ // DCHECK(info->script_scope()->is_script_scope()); |
// Lazy parsed declaration scopes are already partially analyzed. If there are |
// unresolved references remaining, they just need to be resolved in outer |
// scopes. |