chrome/browser/ui/views/content_setting_bubble_contents.h - Issue 23980003: Save password functionality added to the save password bubble

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 23980003: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/content_settings/content_setting_bubble_model.h ('K') | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/content_setting_bubble_contents.h

diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.h b/chrome/browser/ui/views/content_setting_bubble_contents.h

index 24c4efb90238766db95fd1a0b92c5fefc51e4ad5..f80114ac8edbf028ba5164061a31998034b542b1 100644

--- a/chrome/browser/ui/views/content_setting_bubble_contents.h

+++ b/chrome/browser/ui/views/content_setting_bubble_contents.h

@@ -113,6 +113,8 @@ class ContentSettingBubbleContents : public content::NotificationObserver,

views::Link* custom_link_;

Peter Kasting 2013/09/09 18:19:02 Tiny nit: It might be nice to order all these in v

npentrel 2013/09/09 22:08:34 They are not always all used. I think it would be

Peter Kasting 2013/09/10 00:22:11 OK, let me rephrase: I would like these to be in

npentrel 2013/09/10 16:46:38 Ok, I changed it to visual order. I thought it was

views::Link* manage_link_;

views::LabelButton* close_button_;

+ views::LabelButton* never_button_;

+ views::LabelButton* save_button_;

scoped_ptr<views::MenuRunner> menu_runner_;

MediaMenuPartsMap media_menus_;