Save password functionality added to the save password bubble

chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
 
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 13 matching lines @@
 ~BrowserContentSettingBubbleModelDelegate() {
 }
 
 void BrowserContentSettingBubbleModelDelegate::ShowCollectedCookiesDialog(
     content::WebContents* web_contents) {
   chrome::ShowCollectedCookiesDialog(web_contents);
 }
 
 void BrowserContentSettingBubbleModelDelegate::ShowContentSettingsPage(
     ContentSettingsType type) {
   if (type == CONTENT_SETTINGS_TYPE_MIXEDSCRIPT) {

[Peter Kasting, 2013/09/09 18:19:02]

Nit: Consider converting these conditionals to a switch statement.

[npentrel, 2013/09/09 22:08:34]

That would mean creating a lot of cases where nothing happens. I don't think
that would be better as there are only three if branches right now.

[Peter Kasting, 2013/09/10 00:22:11]

?  How so?

switch (type) {
  case CONTENT_SETTINGS_TYPE_MIXEDSCRIPT:
    ...;

  case CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS:
    ...;

  case CONTENT_SETTINGS_TYPE_SAVE_PASSWORD:
    ...;

  default:
    chrome::ShowContentSettings(browser_, type);
    return;
}

(Each of the ... blocks, of course, contains the full content of the current
conditional body blocks.)

[npentrel, 2013/09/10 16:46:38]

Done.

     // We don't (yet?) implement user-settable exceptions for mixed script
     // blocking, so bounce to an explanatory page for now.
     GURL url(google_util::AppendGoogleLocaleParam(
         GURL(kInsecureScriptHelpUrl)));
     chrome::AddSelectedTabWithURL(browser_, url, content::PAGE_TRANSITION_LINK);
     return;
   }
 
   if (type == CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS) {
     chrome::ShowSettingsSubPage(browser_, chrome::kHandlerSettingsSubPage);
     return;
   }
 
+  if (type == CONTENT_SETTINGS_TYPE_SAVE_PASSWORD) {
+    chrome::ShowSettingsSubPage(browser_, chrome::kPasswordManagerSubPage);
+    return;
+  }
+
   chrome::ShowContentSettings(browser_, type);
 }