Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_policy.h

Issue 23980002: Activity Log: allow searching by day (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed error from last rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_policy.h
diff --git a/chrome/browser/extensions/activity_log/activity_log_policy.h b/chrome/browser/extensions/activity_log/activity_log_policy.h
index d185a275a389a8bf515a8db0258c302c2608a95c..a677436d0bad1efc4705d5625d12140c53ba53d3 100644
--- a/chrome/browser/extensions/activity_log/activity_log_policy.h
+++ b/chrome/browser/extensions/activity_log/activity_log_policy.h
@@ -74,30 +74,17 @@ class ActivityLogPolicy {
// state to memory every 5 min.
virtual void ProcessAction(scoped_refptr<Action> action) = 0;
- // Gets all actions for a given extension for the specified day. 0 = today,
- // 1 = yesterday, etc. Only returns 1 day at a time. Actions are sorted from
- // newest to oldest. Results as passed to the specified callback when
- // available.
- //
- // TODO(felt,dbabic) This is overly specific to the current implementation of
- // the FullStreamUIPolicy. We should refactor it to use a more generic read
- // function, for example one that takes a dictionary of query parameters
- // (extension_id, time range, etc.).
- virtual void ReadData(
- const std::string& extension_id,
- const int day,
- const base::Callback
- <void(scoped_ptr<Action::ActionVector>)>& callback) = 0;
-
// Gets all actions that match the specified fields. URLs are treated like
// prefixes; other fields are exact matches. Empty strings are not matched to
- // anything.
+ // anything. For the date: 0 = today, 1 = yesterday, etc.; if the data is
+ // negative, it will be treated as missing.
virtual void ReadFilteredData(
const std::string& extension_id,
const Action::ActionType type,
const std::string& api_name,
const std::string& page_url,
const std::string& arg_url,
+ const int days_ago,
const base::Callback
<void(scoped_ptr<Action::ActionVector>)>& callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698