Linux installer: Add expected_deps*trusty

Linux installer: Add expected_deps*trusty

BUG=564904
Committed: https://crrev.com/dcf75c5d4f3d7fde77f1af6a8c299b0d4f103a84
Cr-Commit-Position: refs/heads/master@{#423756}

[Tom (Use chromium acct), 2016-10-06 19:30:27]

Description was changed from

==========
Linux installer: Add expected_deps*trusty

BUG=
==========

to

==========
Linux installer: Add expected_deps*trusty

BUG=564904
==========

[Tom (Use chromium acct), 2016-10-06 19:30:27]

thomasanderson@google.com changed reviewers:
+ sbc@chromium.org, thestig@chromium.org

[Sam Clegg, 2016-10-06 20:26:24]

lgtm

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
File chrome/installer/linux/debian/build.sh (right):

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
chrome/installer/linux/debian/build.sh:221: HOSTENVIRONMENT="precise"
Perhaps call this DISTRO or RELEASE or LSB_RELEASE?

[Lei Zhang, 2016-10-06 20:41:29]

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
File chrome/installer/linux/debian/build.sh (right):

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
chrome/installer/linux/debian/build.sh:220: if [[ "$(lsb_release -c)" ==
*"precise" ]]; then
Single equal?

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
chrome/installer/linux/debian/build.sh:221: HOSTENVIRONMENT="precise"
On 2016/10/06 20:26:24, Sam Clegg wrote:
> Perhaps call this DISTRO or RELEASE or LSB_RELEASE?

Or at least HOST_ENVIRONMENT?

[Tom (Use chromium acct), 2016-10-06 22:53:36]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[Tom (Use chromium acct), 2016-10-06 22:53:42]

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
File chrome/installer/linux/debian/build.sh (right):

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
chrome/installer/linux/debian/build.sh:220: if [[ "$(lsb_release -c)" ==
*"precise" ]]; then
On 2016/10/06 20:41:29, Lei Zhang wrote:
> Single equal?

Done.

https://codereview.chromium.org/2397993003/diff/1/chrome/installer/linux/debi...
chrome/installer/linux/debian/build.sh:221: HOSTENVIRONMENT="precise"
On 2016/10/06 20:26:24, Sam Clegg wrote:
> Perhaps call this DISTRO or RELEASE or LSB_RELEASE?

Done.

[commit-bot: I haz the power, 2016-10-06 22:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 22:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 22:57:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Zhang, 2016-10-06 22:57:30]

lgtm, but patch did not apply on some bots?

[Tom (Use chromium acct), 2016-10-06 23:20:24]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-06 23:20:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2397993003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-06 23:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 00:19:56]

Description was changed from

==========
Linux installer: Add expected_deps*trusty

BUG=564904
==========

to

==========
Linux installer: Add expected_deps*trusty

BUG=564904
==========

[commit-bot: I haz the power, 2016-10-07 00:19:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 00:22:09]

Description was changed from

==========
Linux installer: Add expected_deps*trusty

BUG=564904
==========

to

==========
Linux installer: Add expected_deps*trusty

BUG=564904

Committed: https://crrev.com/dcf75c5d4f3d7fde77f1af6a8c299b0d4f103a84
Cr-Commit-Position: refs/heads/master@{#423756}
==========

[commit-bot: I haz the power, 2016-10-07 00:22:12]

Patchset 3 (id:??) landed as
https://crrev.com/dcf75c5d4f3d7fde77f1af6a8c299b0d4f103a84
Cr-Commit-Position: refs/heads/master@{#423756}