GrTessellator: refactor Line out of Edge.

GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003

Committed: https://skia.googlesource.com/skia/+/49df8d17c56ee08ecf860289d501913d356f67dc

[Stephen White, 2016-10-06 21:11:51]

Description was changed from

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
==========

to

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003
==========

[Stephen White, 2016-10-06 21:24:04]

Description was changed from

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003
==========

to

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003
==========

[Stephen White, 2016-10-06 21:24:04]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2016-10-06 21:24:43]

[Not sure if Rietveld still works for Skia; let me know if I need to submit to
Gerrit instead.]

PTAl. Thanks!

[robertphillips, 2016-10-07 13:30:58]

lgtm

https://codereview.chromium.org/2397963003/diff/40001/src/gpu/GrTessellator.cpp
File src/gpu/GrTessellator.cpp (right):

https://codereview.chromium.org/2397963003/diff/40001/src/gpu/GrTessellator.c...
src/gpu/GrTessellator.cpp:1438: // This is different from Edge::intersect, in
that it intersects lines, not line segments.
Should this somehow be associated more explicitly with the Line class ?

[Stephen White, 2016-10-07 15:03:20]

https://codereview.chromium.org/2397963003/diff/40001/src/gpu/GrTessellator.cpp
File src/gpu/GrTessellator.cpp (right):

https://codereview.chromium.org/2397963003/diff/40001/src/gpu/GrTessellator.c...
src/gpu/GrTessellator.cpp:1438: // This is different from Edge::intersect, in
that it intersects lines, not line segments.
On 2016/10/07 13:30:58, robertphillips wrote:
> Should this somehow be associated more explicitly with the Line class ? 

Done.

[Stephen White, 2016-10-07 15:04:29]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 15:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:22:02]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-10-07 15:25:35]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-10-07 15:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2397963003/#ps60001
(title: "Move intersect() into Line.")

[commit-bot: I haz the power, 2016-10-07 15:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 15:36:57]

Description was changed from

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003
==========

to

==========
GrTessellator: refactor Line out of Edge.

There are cases where we need only a line equation, and not a full
Edge. Create a Line struct for this, and refactor Edge to use it.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397963003

Committed:
https://skia.googlesource.com/skia/+/49df8d17c56ee08ecf860289d501913d356f67dc
==========

[commit-bot: I haz the power, 2016-10-07 15:36:58]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/49df8d17c56ee08ecf860289d501913d356f67dc