Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_tables.cc

Issue 2397943004: predictors: Use redirect data in prefetch. (Closed)
Patch Set: Non-empty check. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_tables.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_tables.cc b/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
index be1d55179a18c18842b1201b74fe6a1d9f34c524..eca2c77ee31104dcffa174b80492a1c367990294 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
@@ -115,16 +115,6 @@ void ResourcePrefetchPredictorTables::TrimRedirects(
new_end, data->mutable_redirect_endpoints()->end());
}
-// static
-void ResourcePrefetchPredictorTables::SortRedirects(RedirectData* data) {
- std::sort(data->mutable_redirect_endpoints()->begin(),
- data->mutable_redirect_endpoints()->end(),
- [](const RedirectStat& x, const RedirectStat& y) {
- // Decreasing score ordering.
- return ComputeRedirectScore(x) > ComputeRedirectScore(y);
- });
-}
-
void ResourcePrefetchPredictorTables::GetAllData(
PrefetchDataMap* url_data_map,
PrefetchDataMap* host_data_map,
@@ -288,11 +278,6 @@ void ResourcePrefetchPredictorTables::GetAllRedirectDataHelper(
data_map->insert(std::make_pair(key, data));
DCHECK_EQ(data.primary_key(), key);
}
-
- // Sort each of the redirect vectors by score.
- for (auto& kv : *data_map) {
- SortRedirects(&(kv.second));
- }
}
bool ResourcePrefetchPredictorTables::UpdateDataHelper(
@@ -372,13 +357,6 @@ float ResourcePrefetchPredictorTables::ComputeResourceScore(
}
// static
-float ResourcePrefetchPredictorTables::ComputeRedirectScore(
- const RedirectStat& data) {
- // TODO(alexilin): Invent some scoring.
- return 0.0;
-}
-
-// static
bool ResourcePrefetchPredictorTables::DropTablesIfOutdated(
sql::Connection* db) {
int version = GetDatabaseVersion(db);

Powered by Google App Engine
This is Rietveld 408576698