Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2397933006: Get more tests passing on windows (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -120 lines) Patch
M pkg/analyzer/test/generated/analysis_context_factory.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/bazel_summary_test.dart View 6 chunks +22 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 34 chunks +116 lines, -98 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-08 16:35:18 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-08 16:42:39 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-08 18:09:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
789fd11ebf31d9955e6ae4628baa11ba7dd3af70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698