Handle media access permission request

android_webview/native/permission/permission_request_handler.cc

Index: android_webview/native/permission/permission_request_handler.cc
diff --git a/android_webview/native/permission/permission_request_handler.cc b/android_webview/native/permission/permission_request_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..25dfb7c77b7022fc600f9bbc5dbb73f856bef575
--- /dev/null
+++ b/android_webview/native/permission/permission_request_handler.cc
@@ -0,0 +1,83 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/native/permission/permission_request_handler.h"
+
+#include "android_webview/native/permission/aw_permission_request.h"
+#include "android_webview/native/permission/aw_permission_request_delegate.h"
+#include "android_webview/native/permission/permission_request_handler_client.h"
+#include "base/android/scoped_java_ref.h"
+#include "base/bind.h"
+
+using base::android::ScopedJavaLocalRef;
+
+namespace android_webview {
+
+PermissionRequestHandler::PermissionRequestHandler(
+    PermissionRequestHandlerClient* client)
+    : client_(client) {
+}
+
+PermissionRequestHandler::~PermissionRequestHandler() {
+  for (RequestIterator i = requests_.begin(); i != requests_.end(); ++i)
+    CancelRequest(i);
+}
+
+void PermissionRequestHandler::SendRequest(
+    scoped_ptr<AwPermissionRequestDelegate> request) {
+  AwPermissionRequest* aw_request = new AwPermissionRequest(request.Pass());
+  ScopedJavaLocalRef<jobject> java_ref = aw_request->CreateJavaPeer();

[mkosiba (inactive), 2014/04/29 17:29:53]

this is a bit confusing - you're creating the java peer but not using it?

[michaelbai, 2014/04/29 19:28:05]

Done.

+  if (!java_ref.is_null()) {
+    requests_.push_back(
+        base::WeakPtr<AwPermissionRequest>(aw_request->GetWeakPtr()));
+    client_->OnPermissionRequest(aw_request);
+  }
+  PruneRequests();

[mkosiba (inactive), 2014/04/29 17:29:53]

If you register the PermissionRequestHandler as an observer to the
AwPermissionRequest (and add a ondestroyed notification to the observers) you
should be able to know exactly when to remove requests from the list.

[michaelbai, 2014/04/29 19:28:05]

There was a callback like observer, Using weakref here is to remove that
interface and make design simpler.


On 2014/04/29 17:29:53, mkosiba wrote:

+}
+
+void PermissionRequestHandler::CancelRequest(const GURL& origin,
+                                             int64 resources) {
+  // The request list might have multiple requests with same origin and
+  // resources.
+  RequestIterator i = FindRequest(origin, resources);
+  while (i != requests_.end()) {
+    CancelRequest(i);
+    requests_.erase(i);
+    i = FindRequest(origin, resources);
+  }
+}
+
+PermissionRequestHandler::RequestIterator
+PermissionRequestHandler::FindRequest(const GURL& origin,
+                                      int64 resources) {
+  RequestIterator i;
+  for (i = requests_.begin(); i != requests_.end(); ++i) {
+    if (i->get() && i->get()->GetOrigin() == origin &&
+        i->get()->GetResources() == resources) {
+      break;
+    }
+  }
+  return i;
+}
+
+void PermissionRequestHandler::CancelRequest(RequestIterator i) {
+  if (i->get())
+    client_->OnPermissionRequestCanceled(i->get());
+  // The request's grant()/deny() could be called upon
+  // OnPermissionRequestCanceled. Delete AwPermissionRequest if it still
+  // exists.
+  if (i->get())
+    delete i->get();
+}
+
+void PermissionRequestHandler::PruneRequests() {
+  for (RequestIterator i = requests_.begin(); i != requests_.end();) {
+    if (!i->get())
+      i = requests_.erase(i);
+    else
+      ++i;
+  }
+}
+
+}  // namespace android_webivew