Handle media access permission request

android_webview/native/permission/permission_request_handler.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/native/permission/permission_request_handler.h"
+
+#include "android_webview/native/aw_contents.h"
+#include "base/android/scoped_java_ref.h"
+
+using base::android::ScopedJavaLocalRef;
+
+namespace android_webview {
+
+PermissionRequestHandler::PermissionRequestHandler(AwContents* aw_contents)
+    : aw_contents_(aw_contents) {
+}
+
+PermissionRequestHandler::~PermissionRequestHandler() {
+  for (RequestIterator i = requests_.begin(); i != requests_.end(); ++i)
+    CancelRequest(i);
+}
+
+void PermissionRequestHandler::SendRequest(
+    scoped_refptr<AwPermissionRequest> request) {
+  ScopedJavaLocalRef<jobject> java_ref = request->CreateJavaPeer(
+      base::Bind(&PermissionRequestHandler::OnRequestProcessed,

[benm (inactive), 2014/04/16 14:51:10]

do we need a callback here? Would it be better to just pass |this| and have the
permssion request invoke onRequestProcessed directly?

[michaelbai, 2014/04/22 20:53:51]

If just passing this, PermissionRequestHandler and AwPermissionRequest will know
each other. I'd prefer AwPermissionRequest doesn't know anything about
PermissionRequestHandler.

This callback is considering as a observer method, I could add a observer
interface in AwPermissionRequest, but it has only one method. This might be over
skill.

On 2014/04/16 14:51:10, benm wrote:

+                 base::Unretained(this)));
+  if (!java_ref.is_null()) {
+    requests_.push_back(request);
+    aw_contents_->OnPermissionRequest(java_ref);
+  }
+}
+
+void PermissionRequestHandler::CancelRequest(const GURL& origin,
+                                             int64 resources) {
+  RequestIterator i = FindRequest(origin, resources);
+  while (i != requests_.end()) {

[mkosiba (inactive), 2014/04/17 10:34:06]

could you explain why we need this loop?

[michaelbai, 2014/04/22 20:53:51]

See added comment


On 2014/04/17 10:34:06, mkosiba wrote:

+    CancelRequest(i);
+    requests_.erase(i);
+    i = FindRequest(origin, resources);
+  }
+}
+
+void PermissionRequestHandler::OnRequestProcessed(
+    scoped_refptr<AwPermissionRequest> request) {
+  RequestIterator i =
+      FindRequest(request->GetOrigin(), request->GetResources());
+  if (i != requests_.end())
+    requests_.erase(i);
+}
+
+PermissionRequestHandler::RequestIterator
+PermissionRequestHandler::FindRequest(const GURL& origin,

[mkosiba (inactive), 2014/04/17 10:34:06]

please explain why can't we look requests up by comparing pointers?

[michaelbai, 2014/04/22 20:53:51]

Comparing by pointers requires caller keep reference of AwPermissionRequest, but
it is no necessary, just like current implementation.

On 2014/04/17 10:34:06, mkosiba wrote:

+                                      int64 resources) {
+  RequestIterator i;
+  for (i = requests_.begin(); i != requests_.end(); ++i) {
+    if (i->get()->GetOrigin() == origin &&
+        i->get()->GetResources() == resources) {
+      break;
+    }
+  }
+  return i;
+}
+
+void PermissionRequestHandler::CancelRequest(RequestIterator i) {
+  ScopedJavaLocalRef<jobject> java_ref = i->get()->GetJavaObject();
+  if (!java_ref.is_null())
+    aw_contents_->OnPermissionRequestCanceled(java_ref);
+}
+
+}  // namespace android_webivew