Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2397903003: Speculative fix for libPowerStretch.so crash. (Closed)

Created:
4 years, 2 months ago by Peter Wen
Modified:
4 years, 2 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, DmitrySkiba
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for libPowerStretch.so crash. Disable View System hardware acceleration to see if users on this specific device no longer crash in M54. BUG=651918 Committed: https://crrev.com/75123780fa0233b4a3d35576b9fcf386ff856035 Cr-Commit-Position: refs/heads/master@{#423725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Peter Wen
PTAL, we can see if these users stop crashing.
4 years, 2 months ago (2016-10-06 22:03:59 UTC) #2
aelias_OOO_until_Jul13
lgtm. I have a GT-S7580 on my desk and locally applied the patch to observe ...
4 years, 2 months ago (2016-10-06 22:30:26 UTC) #3
Peter Wen
+tedchoc@ for ChromeActivity.java OWNERS. Thanks for checking on device, Alexandre!
4 years, 2 months ago (2016-10-06 22:34:07 UTC) #5
Ted C
lgtm
4 years, 2 months ago (2016-10-06 22:38:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397903003/1
4 years, 2 months ago (2016-10-06 22:58:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 23:18:40 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:19:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75123780fa0233b4a3d35576b9fcf386ff856035
Cr-Commit-Position: refs/heads/master@{#423725}

Powered by Google App Engine
This is Rietveld 408576698