Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2397883002: Convert drag event position to root frame. (Closed)

Created:
4 years, 2 months ago by hush (inactive)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Convert drag event position to root frame. The drag event positions are in viewport's coordinates when they are passed in blink::WebView. We then need to convert these coordinates into the root frame. In this way, the page scale factor is properly factored into the coordination conversion. BUG=651626, 652789 Review-Url: https://codereview.chromium.org/2396693002 Cr-Commit-Position: refs/heads/master@{#423250} (cherry picked from commit 3d4fa85236725f161e2870a69faaca75c4e2a67d) Conflicts: third_party/WebKit/Source/web/WebViewImpl.cpp third_party/WebKit/Source/web/WebViewImpl.h third_party/WebKit/public/web/WebView.h Committed: https://chromium.googlesource.com/chromium/src/+/4eab7d2715b508e2893a6bd62919aa44a3c20f41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 6 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hush (inactive)
4 years, 2 months ago (2016-10-05 20:26:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4eab7d2715b508e2893a6bd62919aa44a3c20f41.

Powered by Google App Engine
This is Rietveld 408576698