Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2397873004: Prune createVisibleSelectionDeprecated from CreateLinkCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from CreateLinkCommand A previous patch (crrev.com/2391723006) ensured clean layout but forgot to rename the function call from createVisibleSelectionDeprecated to createVisibleSelection. This patch does the renaming. BUG=651373 Committed: https://crrev.com/8546160b3124094034c53aafef3da4d349a6bef9 Cr-Commit-Position: refs/heads/master@{#423491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-06 08:19:10 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-06 09:33:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397873004/1
4 years, 2 months ago (2016-10-06 09:34:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 09:42:39 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 09:46:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8546160b3124094034c53aafef3da4d349a6bef9
Cr-Commit-Position: refs/heads/master@{#423491}

Powered by Google App Engine
This is Rietveld 408576698