Include optimized code in JIT app snapshots.

Include optimized code in JIT app snapshots.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/ad32e93c05db8a04ba3898c4db346d8f458c7c9f

[rmacnak, 2016-10-06 17:55:50]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-10-06 23:50:01]

lgtm

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1543: }
Why not write this as:

if (code->ptr()->active_instructions_ != code->ptr()->instructions_) {
  instr = code->ptr()->active_instructions_;
  text_offset = s->GetTextOffset(instr, code);
}
s->Write<int32>(text_offset);

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1643: #endif
Can we order the fields to be in sync with the write side for clarity

deopt_info_array_ = 
static_calls_target_table_ = 
#if defined(PRODUCT)
inlined_metadata_ =
return_address_metadata_ =
#else
inlined_metadata_ =
return_address_metadata_ =
#endif
code_source_map_ =
comments_ =

[kasperl, 2016-10-07 06:14:56]

kasperl@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2016-10-07 06:14:56]

Very cool stuff! With this do the app snapshots contain both optimized and
unoptimized code for the optimized functions or is the unoptimized code
re-generated lazily on-demand (deopt)?

[rmacnak, 2016-10-07 17:29:42]

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1543: }
On 2016/10/06 23:50:00, siva wrote:
> Why not write this as:
> 
> if (code->ptr()->active_instructions_ != code->ptr()->instructions_) {
>   instr = code->ptr()->active_instructions_;
>   text_offset = s->GetTextOffset(instr, code);
> }
> s->Write<int32>(text_offset);

Done.

https://codereview.chromium.org/2397853003/diff/20001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1643: #endif
On 2016/10/06 23:50:00, siva wrote:
> Can we order the fields to be in sync with the write side for clarity
> 
> deopt_info_array_ = 
> static_calls_target_table_ = 
> #if defined(PRODUCT)
> inlined_metadata_ =
> return_address_metadata_ =
> #else
> inlined_metadata_ =
> return_address_metadata_ =
> #endif
> code_source_map_ =
> comments_ = 
> 

The goal is to initialize the fields in declaration order. Reordered the fields
to reduce duplication here.

[rmacnak, 2016-10-07 17:32:46]

On 2016/10/07 06:14:56, kasperl wrote:
> Very cool stuff! With this do the app snapshots contain both optimized and
> unoptimized code for the optimized functions or is the unoptimized code
> re-generated lazily on-demand (deopt)?

With this change they contain both. The intent is to later add a clean up pass
before snapshotting and only include one code per function.

[rmacnak, 2016-10-07 17:35:01]

Description was changed from

==========
Include optimized code in JIT app snapshots.
==========

to

==========
Include optimized code in JIT app snapshots.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ad32e93c05db8a04ba3898c4db346d8f458c7c9f
==========

[rmacnak, 2016-10-07 17:35:02]

Committed patchset #3 (id:40001) manually as
ad32e93c05db8a04ba3898c4db346d8f458c7c9f (presubmit successful).