Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Side by Side Diff: cc/proto/layer.proto

Issue 2397843003: cc/blimp: Add (de)-serialization for PictureLayer and ScrollbarLayer. (Closed)
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 import "display_item.proto"; 7 import "display_item.proto";
8 import "layer_position_constraint.proto"; 8 import "layer_position_constraint.proto";
9 import "layer_sticky_position_constraint.proto"; 9 import "layer_sticky_position_constraint.proto";
10 import "point3f.proto"; 10 import "point3f.proto";
(...skipping 26 matching lines...) Expand all
37 }; 37 };
38 38
39 // required 39 // required
40 optional int32 id = 1; 40 optional int32 id = 1;
41 // required 41 // required
42 optional Type type = 2; 42 optional Type type = 2;
43 optional int32 parent_id = 3; 43 optional int32 parent_id = 3;
44 // A List of all the children of the current LayerNode. 44 // A List of all the children of the current LayerNode.
45 repeated LayerNode children = 4; 45 repeated LayerNode children = 4;
46 optional LayerNode mask_layer = 5; 46 optional LayerNode mask_layer = 5;
47
48 // Set for SolidColorScrollbarLayers.
49 optional SolidColorScrollbarLayerProperties solid_scrollbar = 7;
47 } 50 }
48 51
49 // A container for a list of dirty layers. 52 // A container for a list of dirty layers.
50 message LayerUpdate { 53 message LayerUpdate {
51 // A list of dirty layers. 54 // A list of dirty layers.
52 repeated LayerProperties layers = 1; 55 repeated LayerProperties layers = 1;
53 } 56 }
54 57
55 message LayerProperties { 58 message LayerProperties {
56 // required 59 // required
57 optional int32 id = 1; 60 optional int32 id = 1;
58 61
59 // The properties below are only read if |needs_push_properties| is set. 62 // The properties below are only read if |needs_push_properties| is set.
60 // The Layer base class and each descendant have different proto messages 63 // The Layer base class and each descendant have different proto messages
61 // for their specific properties. 64 // for their specific properties.
62 optional BaseLayerProperties base = 5; 65 optional BaseLayerProperties base = 5;
63 66
64 // Only one of these fields may be set per LayerProperties. 67 // Only one of these fields may be set per LayerProperties.
65 // TODO(dtrainor): use a 'oneof' union when it's supported in Chromium. See 68 // TODO(dtrainor): use a 'oneof' union when it's supported in Chromium. See
66 // crbug.com/570371. 69 // crbug.com/570371.
67 optional PictureLayerProperties picture = 6; 70 optional PictureLayerProperties picture = 6;
68 optional SolidColorScrollbarLayerProperties solid_scrollbar = 7;
69 } 71 }
70 72
71 // NEXT ID: 59 73 // NEXT ID: 59
72 message BaseLayerProperties { 74 message BaseLayerProperties {
73 // The following fields mirror the data stored in Layer::Inputs ---------- 75 // The following fields mirror the data stored in Layer::Inputs ----------
74 optional Rect update_rect = 46; 76 optional Rect update_rect = 46;
75 optional Size bounds = 3; 77 optional Size bounds = 3;
76 optional bool masks_to_bounds = 14; 78 optional bool masks_to_bounds = 14;
77 optional float opacity = 22; 79 optional float opacity = 22;
78 optional SkXfermode.Mode blend_mode = 23; 80 optional SkXfermode.Mode blend_mode = 23;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 optional bool transform_is_invertible = 34; 141 optional bool transform_is_invertible = 34;
140 optional int32 num_descendants_that_draw_content = 36; 142 optional int32 num_descendants_that_draw_content = 36;
141 repeated int32 scroll_children_ids = 41; 143 repeated int32 scroll_children_ids = 41;
142 repeated int32 clip_children_ids = 43; 144 repeated int32 clip_children_ids = 43;
143 145
144 // TODO(nyquist): Figure out what to do with LayerAnimationController. 146 // TODO(nyquist): Figure out what to do with LayerAnimationController.
145 // optional LayerAnimationController layer_animation_controller = ???; 147 // optional LayerAnimationController layer_animation_controller = ???;
146 } 148 }
147 149
148 message PictureLayerProperties { 150 message PictureLayerProperties {
151 // The following fields mirror the data stored in
152 // PictureLayer::PictureLayerInputs.------------------------
vmpstr 2016/10/07 23:50:05 Style nit: do you really need -----, can we just s
Khushal 2016/10/08 00:41:33 I did it in the layer proto so did it here just to
153 optional bool nearest_neighbor = 5;
154 optional Rect recorded_viewport = 7;
155 optional DisplayItemList display_list = 8;
156 // --------------------------------------------------------
157
158 // TODO(khushalsagar): Remove these when crbug.com/648442
149 optional RecordingSource recording_source = 1; 159 optional RecordingSource recording_source = 1;
150 optional Region invalidation = 2; 160 optional Region invalidation = 2;
151 optional Rect last_updated_visible_layer_rect = 3; 161 optional Rect last_updated_visible_layer_rect = 3;
152 optional bool is_mask = 4; 162 optional bool is_mask = 4;
153 optional bool nearest_neighbor = 5;
154
155 optional int64 update_source_frame_number = 6; 163 optional int64 update_source_frame_number = 6;
156
157 optional Rect recorded_viewport = 7;
158 optional DisplayItemList display_list = 8;
159 } 164 }
160 165
161 message SolidColorScrollbarLayerProperties { 166 message SolidColorScrollbarLayerProperties {
162 enum ScrollbarOrientation { 167 enum ScrollbarOrientation {
163 HORIZONTAL = 0; 168 HORIZONTAL = 0;
164 VERTICAL = 1; 169 VERTICAL = 1;
165 }; 170 };
166 171
167 optional int32 scroll_layer_id = 1; 172 optional int32 scroll_layer_id = 1;
168 optional int32 thumb_thickness = 2; 173 optional int32 thumb_thickness = 2;
169 optional int32 track_start = 3; 174 optional int32 track_start = 3;
170 optional bool is_left_side_vertical_scrollbar = 4; 175 optional bool is_left_side_vertical_scrollbar = 4;
171 optional ScrollbarOrientation orientation = 5; 176 optional ScrollbarOrientation orientation = 5;
172 } 177 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698