cc/blimp: Add (de)-serialization for PictureLayer and ScrollbarLayer.

cc/layers/solid_color_scrollbar_layer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/solid_color_scrollbar_layer.h"
 
 #include <memory>
 
 #include "cc/layers/layer_impl.h"
 #include "cc/layers/solid_color_scrollbar_layer_impl.h"
@@ skipping 29 matching lines @@
                                    int thumb_thickness,
                                    int track_start,
                                    bool is_left_side_vertical_scrollbar,
                                    int scroll_layer_id)
     : scroll_layer_id(Layer::INVALID_ID),
       orientation(orientation),
       thumb_thickness(thumb_thickness),
       track_start(track_start),
       is_left_side_vertical_scrollbar(is_left_side_vertical_scrollbar) {}
 
+SolidColorScrollbarLayer::SolidColorScrollbarLayer(
+    int engine_layer_id,
+    ScrollbarOrientation orientation,
+    int thumb_thickness,
+    int track_start,
+    bool is_left_side_vertical_scrollbar,
+    int scroll_layer_id)
+    : Layer(engine_layer_id),
+      solid_color_scrollbar_layer_inputs_(orientation,
+                                          thumb_thickness,
+                                          track_start,
+                                          is_left_side_vertical_scrollbar,
+                                          scroll_layer_id) {}
+
 SolidColorScrollbarLayer::SolidColorScrollbarLayerInputs::
     ~SolidColorScrollbarLayerInputs() = default;
 
 SolidColorScrollbarLayer::SolidColorScrollbarLayer(
     ScrollbarOrientation orientation,
     int thumb_thickness,
     int track_start,
     bool is_left_side_vertical_scrollbar,
     int scroll_layer_id)
     : solid_color_scrollbar_layer_inputs_(orientation,
                                           thumb_thickness,
                                           track_start,
                                           is_left_side_vertical_scrollbar,
                                           scroll_layer_id) {
   Layer::SetOpacity(0.f);
 }
 
 SolidColorScrollbarLayer::~SolidColorScrollbarLayer() {}
 
 ScrollbarLayerInterface* SolidColorScrollbarLayer::ToScrollbarLayer() {
   return this;
 }
 
+void SolidColorScrollbarLayer::ToLayerNodeProto(proto::LayerNode* proto) const {
+  Layer::ToLayerNodeProto(proto);
+
+  proto::SolidColorScrollbarLayerProperties* scrollbar =
+      proto->mutable_solid_scrollbar();
+  scrollbar->set_scroll_layer_id(
+      solid_color_scrollbar_layer_inputs_.scroll_layer_id);
+  scrollbar->set_thumb_thickness(
+      solid_color_scrollbar_layer_inputs_.thumb_thickness);
+  scrollbar->set_track_start(solid_color_scrollbar_layer_inputs_.track_start);
+  scrollbar->set_is_left_side_vertical_scrollbar(
+      solid_color_scrollbar_layer_inputs_.is_left_side_vertical_scrollbar);
+  scrollbar->set_orientation(ScrollbarOrientationToProto(
+      solid_color_scrollbar_layer_inputs_.orientation));
+}
+
+void SolidColorScrollbarLayer::FromLayerNodeProto(
+    const proto::LayerNode& proto,
+    const LayerIdMap& layer_map,
+    LayerTreeHost* layer_tree_host) {
+  Layer::FromLayerNodeProto(proto, layer_map, layer_tree_host);
+
+  const proto::SolidColorScrollbarLayerProperties& scrollbar =
+      proto.solid_scrollbar();
+  solid_color_scrollbar_layer_inputs_.scroll_layer_id =
+      scrollbar.scroll_layer_id();
+  solid_color_scrollbar_layer_inputs_.thumb_thickness =
+      scrollbar.thumb_thickness();
+  solid_color_scrollbar_layer_inputs_.track_start = scrollbar.track_start();
+  solid_color_scrollbar_layer_inputs_.is_left_side_vertical_scrollbar =
+      scrollbar.is_left_side_vertical_scrollbar();
+  solid_color_scrollbar_layer_inputs_.orientation =
+      ScrollbarOrientationFromProto(scrollbar.orientation());
+}
+
 void SolidColorScrollbarLayer::SetOpacity(float opacity) {
   // The opacity of a solid color scrollbar layer is always 0 on main thread.
   DCHECK_EQ(opacity, 0.f);
   Layer::SetOpacity(opacity);
 }
 
 void SolidColorScrollbarLayer::PushPropertiesTo(LayerImpl* layer) {

[Khushal, 2016/10/06 20:05:40]

While we are it, how does this work? When I read through the code, changing the
scroll layer id doesn't PushProperties, it requests a tree sync?

   Layer::PushPropertiesTo(layer);
   SolidColorScrollbarLayerImpl* scrollbar_layer =
       static_cast<SolidColorScrollbarLayerImpl*>(layer);
 
   scrollbar_layer->SetScrollLayerId(
       solid_color_scrollbar_layer_inputs_.scroll_layer_id);
 }
 
 void SolidColorScrollbarLayer::SetNeedsDisplayRect(const gfx::Rect& rect) {
   // Never needs repaint.
@@ skipping 21 matching lines @@
 
 ScrollbarOrientation SolidColorScrollbarLayer::orientation() const {
   return solid_color_scrollbar_layer_inputs_.orientation;
 }
 
 void SolidColorScrollbarLayer::SetTypeForProtoSerialization(
     proto::LayerNode* proto) const {
   proto->set_type(proto::LayerNode::SOLID_COLOR_SCROLLBAR_LAYER);
 }
 
-void SolidColorScrollbarLayer::LayerSpecificPropertiesToProto(
-    proto::LayerProperties* proto,
-    bool inputs_only) {
-  Layer::LayerSpecificPropertiesToProto(proto, inputs_only);
-
-  proto::SolidColorScrollbarLayerProperties* scrollbar =
-      proto->mutable_solid_scrollbar();
-  scrollbar->set_scroll_layer_id(
-      solid_color_scrollbar_layer_inputs_.scroll_layer_id);
-  scrollbar->set_thumb_thickness(
-      solid_color_scrollbar_layer_inputs_.thumb_thickness);
-  scrollbar->set_track_start(solid_color_scrollbar_layer_inputs_.track_start);
-  scrollbar->set_is_left_side_vertical_scrollbar(
-      solid_color_scrollbar_layer_inputs_.is_left_side_vertical_scrollbar);
-  scrollbar->set_orientation(ScrollbarOrientationToProto(
-      solid_color_scrollbar_layer_inputs_.orientation));
-}
-
-void SolidColorScrollbarLayer::FromLayerSpecificPropertiesProto(
-    const proto::LayerProperties& proto) {
-  Layer::FromLayerSpecificPropertiesProto(proto);
-
-  const proto::SolidColorScrollbarLayerProperties& scrollbar =
-      proto.solid_scrollbar();
-  solid_color_scrollbar_layer_inputs_.scroll_layer_id =
-      scrollbar.scroll_layer_id();
-  solid_color_scrollbar_layer_inputs_.thumb_thickness =
-      scrollbar.thumb_thickness();
-  solid_color_scrollbar_layer_inputs_.track_start = scrollbar.track_start();
-  solid_color_scrollbar_layer_inputs_.is_left_side_vertical_scrollbar =
-      scrollbar.is_left_side_vertical_scrollbar();
-  solid_color_scrollbar_layer_inputs_.orientation =
-      ScrollbarOrientationFromProto(scrollbar.orientation());
-}
-
 }  // namespace cc