Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2397833005: Add a test that rects with fixed-size SVGs don't get invalidated on resize of container. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test that rects with fixed-size SVGs don't get invalidated on resize of container. BUG=649760 Committed: https://crrev.com/631c1189c8cdffa69190680c273fb944d5bb0384 Cr-Commit-Position: refs/heads/master@{#423896}

Patch Set 1 #

Patch Set 2 : none #

Total comments: 2

Patch Set 3 : none #

Patch Set 4 : none #

Messages

Total messages: 15 (9 generated)
chrishtr
4 years, 2 months ago (2016-10-06 22:09:04 UTC) #3
fs
LGTM, thanks! https://codereview.chromium.org/2397833005/diff/20001/third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js File third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js (right): https://codereview.chromium.org/2397833005/diff/20001/third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js#newcode71 third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js:71: assert_false(objectNameSet.has(objectName), "Expected object to be invalidated, but ...
4 years, 2 months ago (2016-10-07 07:55:33 UTC) #8
chrishtr
https://codereview.chromium.org/2397833005/diff/20001/third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js File third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js (right): https://codereview.chromium.org/2397833005/diff/20001/third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js#newcode71 third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js:71: assert_false(objectNameSet.has(objectName), "Expected object to be invalidated, but it was ...
4 years, 2 months ago (2016-10-07 16:41:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397833005/60001
4 years, 2 months ago (2016-10-07 16:43:17 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-07 17:35:55 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 17:37:50 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/631c1189c8cdffa69190680c273fb944d5bb0384
Cr-Commit-Position: refs/heads/master@{#423896}

Powered by Google App Engine
This is Rietveld 408576698