Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Issue 2397823003: [wasm] [asm.js] Fix asm.js issues around floating point globals. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
Reviewers:
aseemgarg, bradn, John
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Fix asm.js issues around floating point globals. Allow fround to take values without dots for globals (the spec allows this subtly). Drop over-restrictive assert preventing floating point globals from working. BUG=v8:4203 R=jpp@chromium.org,aseemgarg@chromium.org Committed: https://crrev.com/e901ccdd183b5f029fec9de8067408560ae4a5ff Cr-Commit-Position: refs/heads/master@{#40013}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M src/asmjs/asm-typer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/asmjs/asm-typer.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
bradn
4 years, 2 months ago (2016-10-05 18:13:22 UTC) #3
aseemgarg
lgtm
4 years, 2 months ago (2016-10-05 18:41:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397823003/40001
4 years, 2 months ago (2016-10-05 18:42:03 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 19:46:09 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:46:29 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e901ccdd183b5f029fec9de8067408560ae4a5ff
Cr-Commit-Position: refs/heads/master@{#40013}

Powered by Google App Engine
This is Rietveld 408576698