Issue 2397813002: Fix context comparisons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2397813002: Fix context comparisons (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson

Modified:
4 years, 2 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
M	pkg/analyzer/lib/file_system/memory_file_system.dart	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/sdk/sdk.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/file_system/memory_file_system_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Turns out it isn't safe to compare path contexts, we need to compare the styles. ...

4 years, 2 months ago (2016-10-05 16:49:11 UTC) #2

Brian Wilkerson

4 years, 2 months ago (2016-10-05 16:57:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b83ca4f8dc38cd846d925aa1e6fdb72fc64b00fd (presubmit successful).