sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 23978010: Support dynamic as type literal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 23978010: Support dynamic as type literal. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change dart2dart renamer. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index c97e070f6e1c36c56da0f223b2f1f03eefdab187..eb211bbc7645fc85560858b71eb3e36d05fdb944 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -314,9 +314,7 @@ class PlaceholderCollector extends Visitor {

return;

}

if (element == compiler.dynamicClass) {

- internalError(

- 'Should never make element placeholder for dynamic type element',

- node: node);

+ return;

}

elementNodes.putIfAbsent(element, () => new Set<Node>()).add(node);

}

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »