Issue 23978009: Default target_platform to None.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23978009: Default target_platform to None. (Closed)

Created:
7 years, 3 months ago by flackr

Modified:
7 years, 3 months ago

Reviewers:
Jói

CC:
grit-developer_googlegroups.com, rohitrao (ping after 24h)

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Visibility:
Public.

Default target_platform to None. TEST="./grit.py unit" passes.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	grit_info.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

flackr

Set default target_platform on Outputs (and Inputs for orthogonality) to fix usage in chromium win. ...

7 years, 3 months ago (2013-09-05 20:15:39 UTC) #1

Message was sent while issue was closed.

LGTM'd by joi in email.

Committed manually as r136