Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: chrome/chrome_common.gypi

Issue 23978005: Fix build breakage on chrome-for-tv (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolved Yuncheol's comment Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/common/font_list_android.cc » ('j') | content/content_common.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'common', 8 'target_name': 'common',
9 'type': 'static_library', 9 'type': 'static_library',
10 'variables': { 10 'variables': {
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 'common/extensions/api/extension_action/page_action_handler.cc', 580 'common/extensions/api/extension_action/page_action_handler.cc',
581 'common/extensions/api/spellcheck/spellcheck_handler.cc', 581 'common/extensions/api/spellcheck/spellcheck_handler.cc',
582 'common/extensions/manifest_handlers/minimum_chrome_version_checker. cc', 582 'common/extensions/manifest_handlers/minimum_chrome_version_checker. cc',
583 'common/extensions/manifest_handlers/nacl_modules_handler.cc', 583 'common/extensions/manifest_handlers/nacl_modules_handler.cc',
584 'common/icon_with_badge_image_source.cc', 584 'common/icon_with_badge_image_source.cc',
585 'common/importer/imported_bookmark_entry.cc', 585 'common/importer/imported_bookmark_entry.cc',
586 'common/importer/importer_bridge.cc', 586 'common/importer/importer_bridge.cc',
587 'common/importer/importer_data_types.cc', 587 'common/importer/importer_data_types.cc',
588 'common/importer/importer_url_row.cc', 588 'common/importer/importer_url_row.cc',
589 'common/net/url_util.cc', 589 'common/net/url_util.cc',
590 'common/pepper_permission_util.cc',
591 'common/spellcheck_common.cc', 590 'common/spellcheck_common.cc',
592 ], 591 ],
592 'conditions': [
jam 2013/09/06 16:22:51 nit: no need to have a nested conditions section h
kjyoun 2013/09/09 00:13:45 chrome-for-tv is based on the Android (meaning tha
jam 2013/09/09 14:57:33 Yes I understand that part, but what you're fixing
kjyoun 2013/09/10 02:21:25 Got it and done! On 2013/09/09 14:57:33, jam wrote
593 ['enable_plugins!=1', {
594 'source!' : [
595 'common/pepper_permission_util.cc',
596 ],
597 }],
598 ],
593 'dependencies!': [ 599 'dependencies!': [
594 '<(DEPTH)/chrome/app/policy/cloud_policy_codegen.gyp:policy', 600 '<(DEPTH)/chrome/app/policy/cloud_policy_codegen.gyp:policy',
595 ], 601 ],
596 }], 602 }],
597 ['OS=="win"', { 603 ['OS=="win"', {
598 'include_dirs': [ 604 'include_dirs': [
599 '<(DEPTH)/breakpad/src', 605 '<(DEPTH)/breakpad/src',
600 '<(DEPTH)/third_party/wtl/include', 606 '<(DEPTH)/third_party/wtl/include',
601 ], 607 ],
602 }], 608 }],
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 'common/metrics/proto/user_action_event.proto', 857 'common/metrics/proto/user_action_event.proto',
852 ], 858 ],
853 'variables': { 859 'variables': {
854 'proto_in_dir': 'common/metrics/proto', 860 'proto_in_dir': 'common/metrics/proto',
855 'proto_out_dir': 'chrome/common/metrics/proto', 861 'proto_out_dir': 'chrome/common/metrics/proto',
856 }, 862 },
857 'includes': [ '../build/protoc.gypi' ], 863 'includes': [ '../build/protoc.gypi' ],
858 }, 864 },
859 ], 865 ],
860 } 866 }
OLDNEW
« no previous file with comments | « no previous file | content/common/font_list_android.cc » ('j') | content/content_common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698