Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2397793002: AudioBuffer numberOfChannels defaults to 1 (Closed)

Created:
4 years, 2 months ago by Raymond Toy
Modified:
4 years, 2 months ago
Reviewers:
tkent, hongchan
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioBuffer numberOfChannels defaults to 1 Also make AudioBufferOptions.length be required. Spec: https://webaudio.github.io/web-audio-api/#audiobufferoptions BUG=648298 TEST=constructor/audiobuffer.html updated Committed: https://crrev.com/5b99bb23039bb2457a509282f8fc9b839072ca8a Cr-Commit-Position: refs/heads/master@{#424462}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html View 1 chunk +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferOptions.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Raymond Toy
PTAL
4 years, 2 months ago (2016-10-05 15:19:04 UTC) #4
hongchan
lgtm
4 years, 2 months ago (2016-10-06 18:48:27 UTC) #7
Raymond Toy
tkent: PTAL as API Owner. A last-minute tweak of the spec says that the number ...
4 years, 2 months ago (2016-10-07 16:04:55 UTC) #9
tkent
lgtm
4 years, 2 months ago (2016-10-11 13:54:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397793002/20001
4 years, 2 months ago (2016-10-11 15:39:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 17:06:12 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:09:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b99bb23039bb2457a509282f8fc9b839072ca8a
Cr-Commit-Position: refs/heads/master@{#424462}

Powered by Google App Engine
This is Rietveld 408576698