Issue 2397783004: Queued ClearBlackList() shouldn't use weak pointer.

Issue 2397783004: Queued ClearBlackList() shouldn't use weak pointer. (Closed)

Created:
4 years, 2 months ago by Scott Hess - ex-Googler

Modified:
4 years, 2 months ago

Reviewers:
RyanSturm

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Queued ClearBlackList() shouldn't use weak pointer. The queue lives in the target, so the weak pointer is redundant. BUG=639087 Committed: https://crrev.com/f96a6cfc648f05efe68f33ce49d672c6e39b0e28 Cr-Commit-Position: refs/heads/master@{#423748}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	components/previews/core/previews_black_list.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 10 (5 generated)

Scott Hess - ex-Googler

Noticed this mistake while reviewing https://codereview.chromium.org/2390773003/

4 years, 2 months ago (2016-10-06 17:47:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397783004/1

4 years, 2 months ago (2016-10-06 23:17:58 UTC) #6

commit-bot: I haz the power

4 years, 2 months ago (2016-10-07 00:06:54 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f96a6cfc648f05efe68f33ce49d672c6e39b0e28
Cr-Commit-Position: refs/heads/master@{#423748}