Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2397783003: Allows prerendering to continue for offline requests even if the url was recently visited. (Closed)

Created:
4 years, 2 months ago by dougarnett
Modified:
4 years, 2 months ago
Reviewers:
pasko, mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allows prerendering to continue for offline requests even if the url was recently visited. This is important for the way the new Download feature works. If a link is taking a while to load, you can choose to download it (which does background load using prerender with ORIGIN_OFFLINE). We indeed were recently trying to visit it but still want to load in the background. BUG=652350 Committed: https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416 Cr-Commit-Position: refs/heads/master@{#423543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dougarnett
4 years, 2 months ago (2016-10-05 22:22:06 UTC) #4
pasko
lgtm
4 years, 2 months ago (2016-10-06 12:09:00 UTC) #7
mmenke
On 2016/10/06 12:09:00, pasko wrote: > lgtm LGTM
4 years, 2 months ago (2016-10-06 15:25:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397783003/1
4 years, 2 months ago (2016-10-06 15:31:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 15:37:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:40:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cafb83e8a6a24bc3df0387959373b1988baf5416
Cr-Commit-Position: refs/heads/master@{#423543}

Powered by Google App Engine
This is Rietveld 408576698