Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2921)

Unified Diff: chrome/browser/extensions/activity_log/activity_database.cc

Issue 2397753005: [sql] Allow storing mmap status in a VIEW instead of meta table. (Closed)
Patch Set: OK, its an older SQLite on iOS. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/predictors/predictor_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_database.cc
diff --git a/chrome/browser/extensions/activity_log/activity_database.cc b/chrome/browser/extensions/activity_log/activity_database.cc
index 246e0e8b8d037b9c0aebb25ee89a3ef043a3fa19..2b4bc9b26646a640b2363986c4ec504d8b723037 100644
--- a/chrome/browser/extensions/activity_log/activity_database.cc
+++ b/chrome/browser/extensions/activity_log/activity_database.cc
@@ -67,9 +67,8 @@ void ActivityDatabase::Init(const base::FilePath& db_name) {
db_.set_page_size(4096);
db_.set_cache_size(32);
- // TODO(shess): The current mitigation for http://crbug.com/537742 stores
- // state in the meta table, which this database does not use.
- db_.set_mmap_disabled();
+ // This db does not use [meta] table, store mmap status data elsewhere.
+ db_.set_mmap_alt_status();
if (!db_.Open(db_name)) {
LOG(ERROR) << db_.GetErrorMessage();
« no previous file with comments | « no previous file | chrome/browser/predictors/predictor_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698