Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2397733002: [interpreter] Module tests in all Ignition variants. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Module tests in all Ignition variants. This makes sure we run the module tests against all variants using Ignition as the first compilation tier. It will henceforth extend the test coverage to the BytecodeGraphBuilder as well. R=neis@chromium.org Committed: https://crrev.com/c22e4278ec262a3f3279dc585a59a56a056c0ac7 Cr-Commit-Position: refs/heads/master@{#39992}

Patch Set 1 #

Patch Set 2 : Also extend test262. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M test/cctest/cctest.status View 1 chunk +8 lines, -6 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 2 chunks +14 lines, -11 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-05 11:52:24 UTC) #3
neis
lgtm. can you please also update test262.status?
4 years, 2 months ago (2016-10-05 11:57:52 UTC) #4
Michael Starzinger
Thanks. Done. Landing.
4 years, 2 months ago (2016-10-05 12:12:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397733002/40001
4 years, 2 months ago (2016-10-05 12:54:34 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 13:06:01 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:06:15 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c22e4278ec262a3f3279dc585a59a56a056c0ac7
Cr-Commit-Position: refs/heads/master@{#39992}

Powered by Google App Engine
This is Rietveld 408576698