Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2397723006: Update lint-test-expectations to check on FlagExpectations (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, skobes
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update lint-test-expectations to check on FlagExpectations lint-test-expectations is the python script used to lint all test expectations files, including TestExpectations, NeverFixTests, virtual test suites, etc. This patch updates the linter to also check for flag-specific expectations in the FlagExpectations/ directory. BUG=644435 Committed: https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223 Cr-Commit-Position: refs/heads/master@{#424014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pdr.
4 years, 2 months ago (2016-10-07 06:09:04 UTC) #2
chrishtr
lgtm
4 years, 2 months ago (2016-10-07 18:29:46 UTC) #3
skobes
lgtm
4 years, 2 months ago (2016-10-07 19:46:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397723006/1
4 years, 2 months ago (2016-10-07 23:24:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 23:36:08 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 23:39:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223
Cr-Commit-Position: refs/heads/master@{#424014}

Powered by Google App Engine
This is Rietveld 408576698