fpdfsdk/cpdfsdk_document.cpp - Issue 2397723005: Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/cpdfsdk_document.cpp

Issue 2397723005: Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/cpdfsdk_document.cpp

diff --git a/fpdfsdk/cpdfsdk_document.cpp b/fpdfsdk/cpdfsdk_document.cpp

index 677dd835f811020dfdc13001de478ee036326d0d..5966f0e51b0ab0cc0efcb882f1f9f55cd0d39360 100644

--- a/fpdfsdk/cpdfsdk_document.cpp

+++ b/fpdfsdk/cpdfsdk_document.cpp

@@ -162,7 +162,7 @@ UnderlyingPageType* CPDFSDK_Document::GetPage(int nIndex) {

CPDFSDK_InterForm* CPDFSDK_Document::GetInterForm() {

if (!m_pInterForm)

- m_pInterForm = pdfium::MakeUnique<CPDFSDK_InterForm>(this);

+ m_pInterForm = pdfium::MakeUnique<CPDFSDK_InterForm>(this->GetEnv());

return m_pInterForm.get();

Tom Sepez 2016/10/06 18:42:06 nit: this-> is redundant, just GetEnv()

dsinclair 2016/10/06 19:21:23 Done.

}

« no previous file with comments | « no previous file | fpdfsdk/cpdfsdk_interform.h » ('j') | fpdfsdk/cpdfsdk_interform.cpp » ('J')