Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2397723002: [turbofan] Funnel class constructors through TurboFan. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Funnel class constructors through TurboFan. This makes optimization of all class constructors (i.e. both base and derived) go through TurboFan. Note some class constructors containing Harmony language features (e.g. super constructor calls or accesses to the new.target value) were already going through TurboFan before. R=bmeurer@chromium.org BUG=v8:5458 Committed: https://crrev.com/3c6bbe07e8033b25e1f64d2e46aadd586f5ed32b Cr-Commit-Position: refs/heads/master@{#40342}

Patch Set 1 #

Patch Set 2 : Recement. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Michael Starzinger
Benedikt: PTAL. Michael: FYI, intended to land after 5.5 branch cut.
4 years, 2 months ago (2016-10-05 11:39:51 UTC) #8
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-05 11:59:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397723002/40001
4 years, 2 months ago (2016-10-17 08:56:01 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 08:58:19 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:58:36 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c6bbe07e8033b25e1f64d2e46aadd586f5ed32b
Cr-Commit-Position: refs/heads/master@{#40342}

Powered by Google App Engine
This is Rietveld 408576698