Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2397633002: Remove fullscreen and mouselock from contentSettings API sample. (Closed)

Created:
4 years, 2 months ago by Matt Giuca
Modified:
4 years, 2 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen and mouselock from contentSettings API sample. These APIs are deprecated (just return dummy data) so it doesn't make sense to show them in a sample extension. BUG=591896 Committed: https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3 Cr-Commit-Position: refs/heads/master@{#423340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/common/extensions/docs/examples/api/contentSettings/popup.html View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/contentSettings/popup.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Matt Giuca
4 years, 2 months ago (2016-10-05 01:35:17 UTC) #2
Devlin
lgtm
4 years, 2 months ago (2016-10-05 16:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397633002/1
4 years, 2 months ago (2016-10-05 23:27:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 23:42:38 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:46:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddd4c1941e58af6ac66b38fce017721a0afe70d3
Cr-Commit-Position: refs/heads/master@{#423340}

Powered by Google App Engine
This is Rietveld 408576698