Revert of [Reland] Refactor WebappRegistry into a singleton instance.

Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset #13 id:240001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
This CL is a reason of failure of
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testShowSplashIcon
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testUmaCustomIcon

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36502

Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/78cf6596040662c0a73c0e4038bc84fb2b3c470a
> Committed: https://crrev.com/6e08a0b7993fb106e3dea796950521cfd04a47cf
> Cr-Original-Commit-Position: refs/heads/master@{#422703}
> Cr-Commit-Position: refs/heads/master@{#423077}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominickn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791

[dvadym, 2016-10-05 13:55:39]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2016-10-05 13:55:39]

Created Revert of [Reland] Refactor WebappRegistry into a singleton instance.

[commit-bot: I haz the power, 2016-10-05 13:55:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 13:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 13:56:39]

Failed to apply patch for
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java:
While running git rm
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java;
  fatal: pathspec
'chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java'
did not match any files

Patch:  D   
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java
Index:
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java
diff --git
a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java
b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java
deleted file mode 100644
index
567fb537f47e6662bae7dc8176e0e97d588f716f..0000000000000000000000000000000000000000
---
a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TestFetchStorageCallback.java
+++ /dev/null
@@ -1,25 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.webapps;
-
-import org.chromium.content.browser.test.util.CallbackHelper;
-
-/**
- * CallbackHelper subclass which implements
WebappRegistry.FetchWebappDataStorageCallback for tests.
- */
-public class TestFetchStorageCallback
-        extends CallbackHelper implements
WebappRegistry.FetchWebappDataStorageCallback {
-    protected WebappDataStorage mStorage;
-
-    @Override
-    public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
-        mStorage = storage;
-        notifyCalled();
-    }
-
-    public WebappDataStorage getStorage() {
-        return mStorage;
-    }
-}

[dominickn, 2016-10-06 00:31:05]

Description was changed from

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#13 id:240001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
This CL is a reason of failure of
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testShowSplashIcon
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testUmaCustomIcon

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test...

Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/78cf6596040662c0a73c0e4038bc84fb2b3c470a
> Committed: https://crrev.com/6e08a0b7993fb106e3dea796950521cfd04a47cf
> Cr-Original-Commit-Position: refs/heads/master@{#422703}
> Cr-Commit-Position: refs/heads/master@{#423077}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
==========

to

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#13 id:240001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
This CL is a reason of failure of
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testShowSplashIcon
org.chromium.chrome.browser.webapps.WebappSplashScreenIconTest#testUmaCustomIcon

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test...

Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/78cf6596040662c0a73c0e4038bc84fb2b3c470a
> Committed: https://crrev.com/6e08a0b7993fb106e3dea796950521cfd04a47cf
> Cr-Original-Commit-Position: refs/heads/master@{#422703}
> Cr-Commit-Position: refs/heads/master@{#423077}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
==========