Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/gn.py

Issue 2397623003: Run GN from build.py if the output directory doesn't exist (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/build.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 9ebe0f0f733e263652619c4ce2f67d685379871c..5fb46423549e07b4df56290b948a1b0c1e80cb97 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -99,10 +99,12 @@ def to_gn_args(args, mode, arch, target_os):
# 'is_debug', 'is_release' and 'is_product'.
gn_args['dart_runtime_mode'] = 'develop'
- if host_os == 'win':
- gn_args['is_clang'] = False
- else:
- gn_args['is_clang'] = args.clang and args.os not in ['android']
+ # TODO(zra): Investigate using clang with these configurations.
+ has_clang = (host_os != 'win'
+ and args.os not in ['android']
+ and not gn_args['target_cpu'].startswith('arm')
+ and not gn_args['target_cpu'].startswith('mips'))
+ gn_args['is_clang'] = args.clang and has_clang
if args.target_sysroot:
gn_args['target_sysroot'] = args.target_sysroot
@@ -281,7 +283,7 @@ def main(argv):
endtime = time.time()
if args.verbose:
- print "GN Time: " + str(endtime - starttime) + " seconds"
+ print ("GN Time: %.3f seconds" % (endtime - starttime))
return 0
« no previous file with comments | « tools/build.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698