Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2397623003: Run GN from build.py if the output directory doesn't exist (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run GN from build.py if the output directory doesn't exist R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ff7ad2a4e1833f649e364696fac25280725ce0fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M tools/build.py View 2 chunks +29 lines, -15 lines 0 comments Download
M tools/gn.py View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-10-05 05:04:55 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-10-05 13:51:28 UTC) #3
zra
4 years, 2 months ago (2016-10-05 16:16:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff7ad2a4e1833f649e364696fac25280725ce0fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698