Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: test/mjsunit/modules-namespace1.js

Issue 2397603003: [runtime] Let native setters have a return value. (Closed)
Patch Set: Ouch. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es6/reflect.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/modules-namespace1.js
diff --git a/test/mjsunit/modules-namespace1.js b/test/mjsunit/modules-namespace1.js
index beb469efa4e1651a257c1ccf6ca7130d5df5b201..227b9c8a4c822f43e8ed1a4a5f51a5db62c986cf 100644
--- a/test/mjsunit/modules-namespace1.js
+++ b/test/mjsunit/modules-namespace1.js
@@ -32,8 +32,8 @@ assertEquals(
Reflect.getOwnPropertyDescriptor(foo, "yo"));
assertFalse(Reflect.deleteProperty(foo, "yo"));
assertTrue(Reflect.has(foo, "yo"));
-// TODO(neis): The next three should be False.
-assertTrue(Reflect.set(foo, "yo", true));
+assertFalse(Reflect.set(foo, "yo", true));
+// TODO(neis): The next two should be False.
assertTrue(Reflect.defineProperty(foo, "yo",
Reflect.getOwnPropertyDescriptor(foo, "yo")));
assertTrue(Reflect.defineProperty(foo, "yo", {}));
« no previous file with comments | « test/mjsunit/es6/reflect.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698