[Findit] Cloud Endpoints API to receive reports on flakes.

[Findit] Cloud Endpoints API to receive reports on flakes.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/227ff3d61d3434f5b6c65c97770bbd864df386b5

[stgao, 2016-10-05 00:14:25]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org, sergiyb@chromium.org

[stgao, 2016-10-05 00:14:26]

Hi forks,

Mind a review of this CL -- the Findit's API for
https://codereview.chromium.org/2387153002/

Thanks,
Shuotao

[lijeffrey, 2016-10-05 07:57:06]

lgtm

https://codereview.chromium.org/2397603002/diff/1/appengine/findit/model/flak...
File appengine/findit/model/flake/flake_analysis_request.py (right):

https://codereview.chromium.org/2397603002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/flake_analysis_request.py:100: def AddBuildStep(
nit: this seems slightly misleading, since a build step may not always be
updated and the calling function doesn't seem to care about the return value.
How about renaming it to 'UpdateBuildSteps' or something similar, since a build
step will not necessarily be added?

Alternatively, break this function into 2 function: 1 that does the updating
portion and returns a bool, and if false, calls self.build_steps.append?

I don't feel particularly strongly about this so leaving it as is is fine too

[stgao, 2016-10-05 14:12:40]

https://codereview.chromium.org/2397603002/diff/1/appengine/findit/model/flak...
File appengine/findit/model/flake/flake_analysis_request.py (right):

https://codereview.chromium.org/2397603002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/flake_analysis_request.py:100: def AddBuildStep(
On 2016/10/05 07:57:06, lijeffrey wrote:
> nit: this seems slightly misleading, since a build step may not always be
> updated and the calling function doesn't seem to care about the return value.
> How about renaming it to 'UpdateBuildSteps' or something similar, since a
build
> step will not necessarily be added?
> 
> Alternatively, break this function into 2 function: 1 that does the updating
> portion and returns a bool, and if false, calls self.build_steps.append?
> 
> I don't feel particularly strongly about this so leaving it as is is fine too

I will leave as is, but use a better name or fix the TODO in a follow-up CL.

[stgao, 2016-10-05 14:12:44]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:12:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 14:59:50]

Description was changed from

==========
[Findit] Cloud Endpoints API to receive reports on flakes.

BUG=
==========

to

==========
[Findit] Cloud Endpoints API to receive reports on flakes.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/227ff3d61d3434f5b6c65c97770bb...
==========

[commit-bot: I haz the power, 2016-10-05 14:59:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/227ff3d61d3434f5b6c65c97770bb...