Handlify JSObject::NormalizeProperties method.

Handlify JSObject::NormalizeProperties method.

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16862

[Toon Verwaest, 2013-09-20 09:32:40]

lgtm with comments

https://codereview.chromium.org/23976010/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4436
src/objects.cc:4436: Map* map(object->map());
Handle<Map>

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4437
src/objects.cc:4437: 
Given that no handle escapes this method, and since there's a loop, lets insert
a new handle-scope here so these handles can be freed after normalizing
properties.

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4497
src/objects.cc:4497: // From here on we cannot fail and we shouldn't GC anymore.
What about putting this into 
{ DisallowHeapAllocation no_allocation;
...
}

rather than having a comment.

[Michael Starzinger, 2013-09-20 10:46:30]

Thanks for the review. Addressed comments. Landing.

https://codereview.chromium.org/23976010/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4436
src/objects.cc:4436: Map* map(object->map());
On 2013/09/20 09:32:41, Toon Verwaest wrote:
> Handle<Map>

Done.

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4437
src/objects.cc:4437: 
On 2013/09/20 09:32:41, Toon Verwaest wrote:
> Given that no handle escapes this method, and since there's a loop, lets
insert
> a new handle-scope here so these handles can be freed after normalizing
> properties.

Done.

https://codereview.chromium.org/23976010/diff/1/src/objects.cc#newcode4497
src/objects.cc:4497: // From here on we cannot fail and we shouldn't GC anymore.
On 2013/09/20 09:32:41, Toon Verwaest wrote:
> What about putting this into 
> { DisallowHeapAllocation no_allocation;
> ...
> }
> 
> rather than having a comment.

Done. Good point!

[Michael Starzinger, 2013-09-20 11:37:32]

Committed patchset #2 manually as r16862 (presubmit successful).