Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 23976008: Roll leveldb to r77. (Closed)

Created:
7 years, 3 months ago by dgrogan
Modified:
7 years, 3 months ago
Reviewers:
alecflett, jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Roll leveldb to r77. Biggest change for chromium is no longer using .sst as the sstable file extension. The .sst extension caused windows system restore to corrupt databases (error message: Corruption: 1 missing files; e.g...). The only other change that could affect chromium is a bugfix, where changing directions on an iterator could yield the wrong value. (https://code.google.com/p/leveldb/issues/detail?id=200) BUG=261623 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrogan
Josh or Alec, could you review this?
7 years, 3 months ago (2013-09-19 21:13:14 UTC) #1
jsbell
lgtm
7 years, 3 months ago (2013-09-19 21:28:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/23976008/1
7 years, 3 months ago (2013-09-19 21:32:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=199629
7 years, 3 months ago (2013-09-20 01:59:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/23976008/1
7 years, 3 months ago (2013-09-20 02:05:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=199836
7 years, 3 months ago (2013-09-20 08:39:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/23976008/1
7 years, 3 months ago (2013-09-20 15:58:37 UTC) #7
dgrogan
7 years, 3 months ago (2013-09-20 18:13:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r224433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698