Disabling BlinkPerfDom on reference build for win and linux

Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/659111dbb9bdd5a690500aa1d8cd6304dcf22354
Cr-Commit-Position: refs/heads/master@{#423527}

[eyaich1, 2016-10-05 16:56:00]

Description was changed from

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
==========

to

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[eyaich1, 2016-10-05 16:57:09]

eyaich@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-10-05 16:59:59]

fmeawad@chromium.org changed reviewers:
+ aiolos@chromium.org

[fmeawad, 2016-10-05 17:00:00]

lgtm

https://codereview.chromium.org/2397583003/diff/1/tools/perf/benchmarks/blink...
File tools/perf/benchmarks/blink_perf.py (right):

https://codereview.chromium.org/2397583003/diff/1/tools/perf/benchmarks/blink...
tools/perf/benchmarks/blink_perf.py:218: possible_browser.platform.GetOSName()
in ['win', 'linux']):
I think you can also use decorators:
win-reference
linux-reference

[eyaich1, 2016-10-05 17:03:10]

On 2016/10/05 17:00:00, fmeawad wrote:
> lgtm
> 
>
https://codereview.chromium.org/2397583003/diff/1/tools/perf/benchmarks/blink...
> File tools/perf/benchmarks/blink_perf.py (right):
> 
>
https://codereview.chromium.org/2397583003/diff/1/tools/perf/benchmarks/blink...
> tools/perf/benchmarks/blink_perf.py:218: possible_browser.platform.GetOSName()
> in ['win', 'linux']):
> I think you can also use decorators:
> win-reference
> linux-reference

I didn't see the linux-reference one used anywhere so I went with this method to
be safe :)

[eyaich1, 2016-10-05 17:03:21]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:03:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:16:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eakuefner, 2016-10-05 17:20:12]

eakuefner@chromium.org changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2016-10-05 17:20:13]

lgtm

[eyaich1, 2016-10-05 17:21:45]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:22:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 19:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:05:16]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[fmeawad, 2016-10-05 19:28:20]

On 2016/10/05 19:05:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no
build
> URL)

Feel free to remove that bot from the list of CQ_INCLUDE_TRYBOTS

[eyaich1, 2016-10-05 22:45:55]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-10-05 22:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2397583003/#ps20001
(title: "Removing timed out bot from CQ")

[commit-bot: I haz the power, 2016-10-05 22:46:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:47:26]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[dominicc (has gone to gerrit), 2016-10-06 06:46:18]

On 2016/10/06 at 00:47:26, commit-bot wrote:
> Try jobs failed on following builders:
>   android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no
build URL)

If this test just failing on the reference build because we don't have modern
DOM methods like append on the reference build? I can rewrite the test to use
appendChild, etc.

[eyaich1, 2016-10-06 12:07:08]

On 2016/10/06 06:46:18, dominicc wrote:
> On 2016/10/06 at 00:47:26, commit-bot wrote:
> > Try jobs failed on following builders:
> >   android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no
> build URL)
> 
> If this test just failing on the reference build because we don't have modern
> DOM methods like append on the reference build? I can rewrite the test to use
> appendChild, etc.

If that is what you think the issue is I am fine with trying to get a fix in. 
It doesn't hurt to disable the tests though and then re-enable them once the fix
goes in. 

Did I remove the bot from the wrong CQ_INCLUDE_TRYBOTS list?

[eyaich1, 2016-10-06 12:08:32]

Description was changed from

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[eyaich1, 2016-10-06 12:14:31]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-10-06 12:14:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2397583003/#ps40001
(title: "Updating presubmit")

[commit-bot: I haz the power, 2016-10-06 12:14:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fmeawad, 2016-10-06 13:48:31]

On 2016/10/06 12:14:42, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

@dominicc, that would be great, but I agree, we disable, fix, reenable.

[commit-bot: I haz the power, 2016-10-06 14:38:19]

Description was changed from

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[commit-bot: I haz the power, 2016-10-06 14:38:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 14:40:31]

Description was changed from

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Disabling BlinkPerfDom on reference build for win and linux

BUG=chromium:652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/659111dbb9bdd5a690500aa1d8cd6304dcf22354
Cr-Commit-Position: refs/heads/master@{#423527}
==========

[commit-bot: I haz the power, 2016-10-06 14:40:32]

Patchset 3 (id:??) landed as
https://crrev.com/659111dbb9bdd5a690500aa1d8cd6304dcf22354
Cr-Commit-Position: refs/heads/master@{#423527}