Index: webrtc/audio/audio_send_stream_unittest.cc |
diff --git a/webrtc/audio/audio_send_stream_unittest.cc b/webrtc/audio/audio_send_stream_unittest.cc |
index c17e8e393cb3f0ead6603fb5692dcbb846d95b71..9295672b78cc7acb95317d610f67ea27fdf7ffab 100644 |
--- a/webrtc/audio/audio_send_stream_unittest.cc |
+++ b/webrtc/audio/audio_send_stream_unittest.cc |
@@ -68,7 +68,6 @@ struct ConfigHelper { |
bitrate_allocator_(&limit_observer_), |
worker_queue_("ConfigHelper_worker_queue") { |
using testing::Invoke; |
- using testing::StrEq; |
EXPECT_CALL(voice_engine_, |
RegisterVoiceEngineObserver(_)).WillOnce(Return(0)); |
@@ -78,40 +77,15 @@ struct ConfigHelper { |
config.voice_engine = &voice_engine_; |
audio_state_ = AudioState::Create(config); |
+ SetupDefaultChannelProxy(); |
+ |
EXPECT_CALL(voice_engine_, ChannelProxyFactory(kChannelId)) |
.WillOnce(Invoke([this](int channel_id) { |
- EXPECT_FALSE(channel_proxy_); |
- channel_proxy_ = new testing::StrictMock<MockVoEChannelProxy>(); |
- EXPECT_CALL(*channel_proxy_, SetRTCPStatus(true)).Times(1); |
- EXPECT_CALL(*channel_proxy_, SetLocalSSRC(kSsrc)).Times(1); |
- EXPECT_CALL(*channel_proxy_, SetRTCP_CNAME(StrEq(kCName))).Times(1); |
- EXPECT_CALL(*channel_proxy_, SetNACKStatus(true, 10)).Times(1); |
- EXPECT_CALL(*channel_proxy_, |
- SetSendAbsoluteSenderTimeStatus(true, kAbsSendTimeId)).Times(1); |
- EXPECT_CALL(*channel_proxy_, |
- SetSendAudioLevelIndicationStatus(true, kAudioLevelId)).Times(1); |
- EXPECT_CALL(*channel_proxy_, EnableSendTransportSequenceNumber( |
- kTransportSequenceNumberId)) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, |
- RegisterSenderCongestionControlObjects( |
- congestion_controller_.pacer(), |
- congestion_controller_.GetTransportFeedbackObserver(), |
- congestion_controller_.packet_router())) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, ResetCongestionControlObjects()) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, RegisterExternalTransport(nullptr)) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, DeRegisterExternalTransport()) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, SetRtcEventLog(testing::NotNull())) |
- .Times(1); |
- EXPECT_CALL(*channel_proxy_, SetRtcEventLog(testing::IsNull())) |
- .Times(1); // Destructor resets the event log |
return channel_proxy_; |
})); |
+ |
SetupMockForSetupSendCodec(); |
+ |
stream_config_.voe_channel_id = kChannelId; |
stream_config_.rtp.ssrc = kSsrc; |
stream_config_.rtp.nack.rtp_history_ms = 200; |
@@ -138,6 +112,36 @@ struct ConfigHelper { |
RtcEventLog* event_log() { return &event_log_; } |
MockVoiceEngine* voice_engine() { return &voice_engine_; } |
+ void SetupDefaultChannelProxy() { |
+ using testing::StrEq; |
+ channel_proxy_ = new testing::StrictMock<MockVoEChannelProxy>(); |
+ EXPECT_CALL(*channel_proxy_, SetRTCPStatus(true)).Times(1); |
+ EXPECT_CALL(*channel_proxy_, SetLocalSSRC(kSsrc)).Times(1); |
+ EXPECT_CALL(*channel_proxy_, SetRTCP_CNAME(StrEq(kCName))).Times(1); |
+ EXPECT_CALL(*channel_proxy_, SetNACKStatus(true, 10)).Times(1); |
+ EXPECT_CALL(*channel_proxy_, |
+ SetSendAbsoluteSenderTimeStatus(true, kAbsSendTimeId)) |
+ .Times(1); |
+ EXPECT_CALL(*channel_proxy_, |
+ SetSendAudioLevelIndicationStatus(true, kAudioLevelId)) |
+ .Times(1); |
+ EXPECT_CALL(*channel_proxy_, |
+ EnableSendTransportSequenceNumber(kTransportSequenceNumberId)) |
+ .Times(1); |
+ EXPECT_CALL(*channel_proxy_, |
+ RegisterSenderCongestionControlObjects( |
+ congestion_controller_.pacer(), |
+ congestion_controller_.GetTransportFeedbackObserver(), |
+ congestion_controller_.packet_router())) |
+ .Times(1); |
+ EXPECT_CALL(*channel_proxy_, ResetCongestionControlObjects()).Times(1); |
+ EXPECT_CALL(*channel_proxy_, RegisterExternalTransport(nullptr)).Times(1); |
+ EXPECT_CALL(*channel_proxy_, DeRegisterExternalTransport()).Times(1); |
+ EXPECT_CALL(*channel_proxy_, SetRtcEventLog(testing::NotNull())).Times(1); |
+ EXPECT_CALL(*channel_proxy_, SetRtcEventLog(testing::IsNull())) |
+ .Times(1); // Destructor resets the event log |
+ } |
+ |
void SetupMockForSetupSendCodec() { |
EXPECT_CALL(voice_engine_, SetVADStatus(kChannelId, false, _, _)) |
.WillOnce(Return(0)); |
@@ -315,6 +319,10 @@ TEST(AudioSendStreamTest, SendCodecAppliesConfigParams) { |
stream_config.send_codec_spec.opus_max_playback_rate = 12345; |
stream_config.send_codec_spec.cng_plfreq = 16000; |
stream_config.send_codec_spec.cng_payload_type = 105; |
+ stream_config.send_codec_spec.min_ptime_ms = 10; |
+ stream_config.send_codec_spec.max_ptime_ms = 60; |
+ stream_config.audio_network_adaptor_config = |
+ rtc::Optional<std::string>("abced"); |
EXPECT_CALL(*helper.voice_engine(), SetFECStatus(kChannelId, true)) |
.WillOnce(Return(0)); |
EXPECT_CALL( |
@@ -331,6 +339,14 @@ TEST(AudioSendStreamTest, SendCodecAppliesConfigParams) { |
kChannelId, stream_config.send_codec_spec.cng_payload_type, |
webrtc::kFreq16000Hz)) |
.WillOnce(Return(0)); |
+ EXPECT_CALL( |
+ *helper.channel_proxy(), |
+ SetReceiverFrameLengthRange(stream_config.send_codec_spec.min_ptime_ms, |
+ stream_config.send_codec_spec.max_ptime_ms)); |
+ EXPECT_CALL( |
+ *helper.channel_proxy(), |
+ EnableAudioNetworkAdaptor(*stream_config.audio_network_adaptor_config)) |
+ .WillOnce(Return(true)); |
internal::AudioSendStream send_stream( |
stream_config, helper.audio_state(), helper.worker_queue(), |
helper.congestion_controller(), helper.bitrate_allocator(), |