Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2397573004: [stubs] Reduce number of StoreTransitionStub instances. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Reduce number of StoreTransitionStub instances. ... by passing a field offset as a runtime parameter. This CL also introduces a StoreMapStub - a special case of a store transition that used to be handled by old StoreTransitionStub. BUG=chromium:648545 Committed: https://crrev.com/360ee4f9b0eeef6da714b799dd6c3cda060643a9 Cr-Commit-Position: refs/heads/master@{#39997}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -76 lines) Patch
M src/code-stub-assembler.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 3 chunks +31 lines, -4 lines 0 comments Download
M src/code-stubs.h View 3 chunks +22 lines, -19 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +36 lines, -34 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/interface-descriptors.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-05 11:42:53 UTC) #5
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-05 14:53:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397573004/40001
4 years, 2 months ago (2016-10-05 14:54:59 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-05 14:57:02 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 14:57:14 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/360ee4f9b0eeef6da714b799dd6c3cda060643a9
Cr-Commit-Position: refs/heads/master@{#39997}

Powered by Google App Engine
This is Rietveld 408576698