Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)
Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
index d4bba360c000291b62a21b7b54d1ff6e80c754ac..603ff9a15c0b772c35844d2f25eaac55384e0212 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
@@ -43,6 +43,9 @@ _log = logging.getLogger(__name__)
# SCM methods are expected to return paths relative to self.checkout_root.
class SCM:
+ # Arguments are generally unused in abstract base methods below.
+ # pylint: disable=unused-argument
+
def __init__(self, cwd, executive=None, filesystem=None):
self.cwd = cwd
self._executive = executive or Executive()
@@ -99,6 +102,9 @@ class SCM:
def find_checkout_root(self, path):
SCM._subclass_must_implement()
+ def add_all(self, pathspec=None):
+ self._subclass_must_implement()
+
def add(self, path, return_exit_code=False, recurse=True):
self.add_list([path], return_exit_code, recurse)
@@ -139,7 +145,7 @@ class SCM:
def blame(self, path):
self._subclass_must_implement()
- def has_working_directory_changes(self):
+ def has_working_directory_changes(self, pathspec=None):
self._subclass_must_implement()
#--------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698