EME: Check capabilities provided only on success

EME: Check capabilities provided only on success

As some applications are providing multiple configurations for
compatability with previous versions, only check that at least
one capability is provided on success, as that is likely to fail
once Chrome starts following the EME spec strictly. This also
avoids the problem of counting both success and failure for the
same configuration (if multiple configs were provided).

BUG=616233
TEST=encrypted media layout tests pass

Committed: https://crrev.com/c0029a951c862120b5cf7b95cec7cc2a92586270
Cr-Commit-Position: refs/heads/master@{#423656}

[jrummell, 2016-10-04 23:13:30]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-10-04 23:13:30]

PTAL

[xhwang, 2016-10-06 17:01:05]

LGTM % nit

https://chromiumcodereview.appspot.com/2397543002/diff/1/third_party/WebKit/S...
File
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
(right):

https://chromiumcodereview.appspot.com/2397543002/diff/1/third_party/WebKit/S...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:284:
void MediaKeySystemAccessInitializer::checkCapabilitiesProvided(
"provided" is a bit ambiguous..

[jrummell, 2016-10-06 18:43:04]

Thanks for the review.

https://codereview.chromium.org/2397543002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
(right):

https://codereview.chromium.org/2397543002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:284:
void MediaKeySystemAccessInitializer::checkCapabilitiesProvided(
On 2016/10/06 17:01:05, xhwang wrote:
> "provided" is a bit ambiguous..

Removed "Provided".

[jrummell, 2016-10-06 18:43:08]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-10-06 18:43:08]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2397543002/#ps20001
(title: "rename")

[commit-bot: I haz the power, 2016-10-06 18:43:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:34:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 20:37:04]

Description was changed from

==========
EME: Check capabilities provided only on success

As some applications are providing multiple configurations for
compatability with previous versions, only check that at least
one capability is provided on success, as that is likely to fail
once Chrome starts following the EME spec strictly. This also
avoids the problem of counting both success and failure for the
same configuration (if multiple configs were provided).

BUG=616233
TEST=encrypted media layout tests pass
==========

to

==========
EME: Check capabilities provided only on success

As some applications are providing multiple configurations for
compatability with previous versions, only check that at least
one capability is provided on success, as that is likely to fail
once Chrome starts following the EME spec strictly. This also
avoids the problem of counting both success and failure for the
same configuration (if multiple configs were provided).

BUG=616233
TEST=encrypted media layout tests pass

Committed: https://crrev.com/c0029a951c862120b5cf7b95cec7cc2a92586270
Cr-Commit-Position: refs/heads/master@{#423656}
==========

[commit-bot: I haz the power, 2016-10-06 20:37:09]

Patchset 2 (id:??) landed as
https://crrev.com/c0029a951c862120b5cf7b95cec7cc2a92586270
Cr-Commit-Position: refs/heads/master@{#423656}