Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2397523004: Reland of ServiceWorker: Added --mojo-service-worker to the browser tests (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
jwd, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ServiceWorker: Added --mojo-service-worker to the browser tests (patchset #1 id:1 of https://codereview.chromium.org/2380723002/ ) Reason for revert: A revert of https://codereview.chromium.org/2227593002 is reverted. Original issue's description: > Revert of ServiceWorker: Added --mojo-service-worker to the browser tests (patchset #2 id:20001 of https://codereview.chromium.org/2357543002/ ) > > Reason for revert: > Revert so a revert of https://codereview.chromium.org/2227593002 will compile. > > Original issue's description: > > ServiceWorker: Added --mojo-service-worker to the browser tests > > > > In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P > > to use the parameterized tests for flipping the flag. > > > > BUG=629701 > > > > Committed: https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9 > > Cr-Commit-Position: refs/heads/master@{#421462} > > TBR=horo@chromium.org,shimazu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629701 > > Committed: https://crrev.com/9fad885c354ebf046e9506f85391cf4585991c05 > Cr-Commit-Position: refs/heads/master@{#421518} TBR=horo@chromium.org,jwd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629701 Committed: https://crrev.com/ab56f249ec0733898a9db6b89391b7c3d9a30ae2 Cr-Commit-Position: refs/heads/master@{#423452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -40 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 35 chunks +80 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shimazu
Created Reland of ServiceWorker: Added --mojo-service-worker to the browser tests
4 years, 2 months ago (2016-10-06 05:36:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397523004/1
4 years, 2 months ago (2016-10-06 05:36:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 06:30:08 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:31:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab56f249ec0733898a9db6b89391b7c3d9a30ae2
Cr-Commit-Position: refs/heads/master@{#423452}

Powered by Google App Engine
This is Rietveld 408576698