Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 23975003: Add widevine_cdm_version.h to gyp for android. (Closed)

Created:
7 years, 3 months ago by xhwang
Modified:
7 years, 3 months ago
Reviewers:
qinmin, ddorwin
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Add widevine_cdm_version.h to gyp for android. - EME API works on Chrome build. - CanPlayType() is suppressed (returns "") by default. - User can choose to override the CanPlayType() suppression with a flag "--override-encrypted-media-canplaytype". - For Android "video/mp4" is supported, while "video/webm" isn't. BUG=163552 TEST=Tested all scenarios listed above. R=ddorwin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221548

Patch Set 1 #

Patch Set 2 : minor fix #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/key_systems_info.cc View 1 chunk +2 lines, -0 lines 2 comments Download
A third_party/widevine/cdm/android/widevine_cdm_version.h View 1 1 chunk +25 lines, -0 lines 1 comment Download
M third_party/widevine/cdm/widevine_cdm.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
This is the updated version of https://codereview.chromium.org/18501017/. PTAL.
7 years, 3 months ago (2013-09-05 17:25:23 UTC) #1
xhwang
https://codereview.chromium.org/23975003/diff/4001/content/renderer/media/crypto/key_systems_info.cc File content/renderer/media/crypto/key_systems_info.cc (right): https://codereview.chromium.org/23975003/diff/4001/content/renderer/media/crypto/key_systems_info.cc#newcode80 content/renderer/media/crypto/key_systems_info.cc:80: #if !defined(OS_ANDROID) We could use something like WIDEVINE_CDM_WEBM_SUPPORT_AVAILABLE here, ...
7 years, 3 months ago (2013-09-05 17:32:38 UTC) #2
ddorwin
lgtm I don't think 224793 really applies to this CL. This CL doesn't make progress ...
7 years, 3 months ago (2013-09-05 17:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/23975003/4001
7 years, 3 months ago (2013-09-05 18:02:08 UTC) #4
xhwang
7 years, 3 months ago (2013-09-06 00:03:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r221548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698