Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: samples/pdfium_test.cc

Issue 2397473006: Remove ownership of CPDFSDK_Document from CPDFXFA_Document (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/pdfium_test.cc
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 35e0d50678baa3592bef364772d5a356ee89a5d8..e0c190470792145b7be4db06e527af9eace466a6 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -87,16 +87,8 @@ static FPDF_FORMFILLINFO_PDFiumTest* ToPDFiumTestFormFillInfo(
}
static void CloseDocAndForm(FPDF_DOCUMENT doc, FPDF_FORMHANDLE form) {
Lei Zhang 2016/10/05 17:14:54 If we end up here, just remove CloseDocAndForm() i
dsinclair 2016/10/05 17:55:57 Done.
-#ifdef PDF_ENABLE_XFA
- // Note: The shut down order here is the reverse of the non-XFA branch order.
- // Need to work out if this is required, and if it is, the lifetimes of
- // objects owned by |doc| that |form| reference.
- FPDF_CloseDocument(doc);
- FPDFDOC_ExitFormFillEnvironment(form);
-#else // PDF_ENABLE_XFA
FPDFDOC_ExitFormFillEnvironment(form);
FPDF_CloseDocument(doc);
-#endif // PDF_ENABLE_XFA
}
static bool CheckDimensions(int stride, int width, int height) {
« fpdfsdk/fpdfxfa/cpdfxfa_document.cpp ('K') | « fpdfsdk/fpdfxfa/cpdfxfa_document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698