Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2397473003: Harden degenerate gradient context handling (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Harden degenerate gradient context handling Certain inputs produce degenerate values at context creation time only. Detect such cases after context creation, and abort drawing by returning a null shader context instead. BUG=skia:5821 R=reed@google.com,brianosman@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397473003 Committed: https://skia.googlesource.com/skia/+/088e21ba652ceaa4abb4ba8cdd2ec1bc8afc32ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M include/core/SkMatrix.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/gradients/Sk4fGradientBase.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +12 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
f(malita)
4 years, 2 months ago (2016-10-04 20:16:58 UTC) #3
reed1
lgtm
4 years, 2 months ago (2016-10-05 16:12:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397473003/1
4 years, 2 months ago (2016-10-05 16:27:27 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 16:28:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/088e21ba652ceaa4abb4ba8cdd2ec1bc8afc32ed

Powered by Google App Engine
This is Rietveld 408576698