Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2397443003: Adds new logging type SYSLOG which logs to the system log. (Closed)

Created:
4 years, 2 months ago by pastarmovj
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Adds new logging type SYSLOG which logs to the system log. On Windows this type logs to the Event Log and on POSIX systems it logs to the messages log (or its equvalent). As a side effect of adding the presubmit check for it this CL fixes running the presumbit checks tests on Windows. BUG=642115 Review-Url: https://codereview.chromium.org/2296783002 Cr-Commit-Position: refs/heads/master@{#419758} (cherry picked from commit 89f7ee10f03d696276adf1cdc901c949a2e091d4) Committed: https://chromium.googlesource.com/chromium/src/+/8d3b68f910ec25e44b210be4d8f3c8fd1fae6bb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +15 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 6 chunks +24 lines, -0 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 2 chunks +5 lines, -0 lines 0 comments Download
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M base/logging.h View 1 chunk +3 lines, -0 lines 0 comments Download
A base/syslog_logging.h View 1 chunk +38 lines, -0 lines 0 comments Download
A base/syslog_logging.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
4 years, 2 months ago (2016-10-05 09:44:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d3b68f910ec25e44b210be4d8f3c8fd1fae6bb3.

Powered by Google App Engine
This is Rietveld 408576698