Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2397433002: Fix codesign.py script when ios_enable_code_signing is set to false. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix codesign.py script when ios_enable_code_signing is set to false. When code signing is disabled, the embedded.mobileprovision file should not be copied into the generated bundle, so move the copy after the check of --disable-code-signature. Remove the embedded.mobileprovision from the bundle if it exists so that switching ios_enable_code_signing from true to false works. BUG=None Committed: https://crrev.com/98ca7be1e2734af19697a244879bac6a059db148 Cr-Commit-Position: refs/heads/master@{#423111}

Patch Set 1 #

Patch Set 2 : Fix ProvisioningProfile.Install comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M build/config/ios/codesign.py View 1 4 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look.
4 years, 2 months ago (2016-10-04 17:26:59 UTC) #6
justincohen
lgtm
4 years, 2 months ago (2016-10-04 17:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397433002/20001
4 years, 2 months ago (2016-10-05 08:16:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 08:21:56 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 08:24:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98ca7be1e2734af19697a244879bac6a059db148
Cr-Commit-Position: refs/heads/master@{#423111}

Powered by Google App Engine
This is Rietveld 408576698